Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix value to bigint conversion #2688

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Mar 17, 2023

This PR should fix the remaining tests in the builtin BigInt test suite

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Mar 17, 2023
@HalidOdat HalidOdat force-pushed the fix/value-to-bigint-conversion branch from fb9ceac to 58f8934 Compare March 17, 2023 15:30
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,998 72,000 +2
Ignored 17,324 17,324 0
Failed 4,955 4,953 -2
Panics 14 14 0
Conformance 76.37% 76.37% +0.00%
Fixed tests (2):
test/built-ins/BigInt/constructor-coercion.js [strict mode] (previously Failed)
test/built-ins/BigInt/constructor-coercion.js (previously Failed)

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #2688 (fb9ceac) into main (50a343a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head fb9ceac differs from pull request most recent head 58f8934. Consider uploading reports for the commit 58f8934 to get more accurate results

@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
+ Coverage   49.33%   49.39%   +0.06%     
==========================================
  Files         397      395       -2     
  Lines       39610    39572      -38     
==========================================
+ Hits        19540    19548       +8     
+ Misses      20070    20024      -46     
Impacted Files Coverage Δ
boa_engine/src/builtins/bigint/mod.rs 85.18% <100.00%> (ø)

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nekevss
Copy link
Member

nekevss commented Mar 17, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 17, 2023
This PR should fix the remaining tests in the builtin `BigInt` test suite
@bors
Copy link

bors bot commented Mar 17, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix value to bigint conversion [Merged by Bors] - Fix value to bigint conversion Mar 17, 2023
@bors bors bot closed this Mar 17, 2023
@bors bors bot deleted the fix/value-to-bigint-conversion branch March 17, 2023 17:26
@HalidOdat HalidOdat added this to the v0.17.0 milestone Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants