[Merged by Bors] - Implement with and object environments
#2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
parser
Test262 conformance changes
Fixed tests (197): |
Codecov Report
@@ Coverage Diff @@
## main #2692 +/- ##
==========================================
+ Coverage 49.36% 50.36% +1.00%
==========================================
Files 397 392 -5
Lines 39568 38897 -671
==========================================
+ Hits 19533 19591 +58
+ Misses 20035 19306 -729
... and 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
requested review from
nekevss,
jedel1043,
Razican,
HalidOdat,
jasonwilliams and
RageKnify
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
This Pull Request changes the following: - Implement `with` statement parsing, ast node, compilation and excution. - Implement object environments that are used in the `with` statement excution. The implementation of object environments can probably be optimized further by using more compile-time information about when object environments can exist. Maybe there could also be a separate environment stack for object environments to reduce the filtering and iteration that is needed with the current implementation. This does not fix all tests in the `test/language/statements/with` suite yet. But for most failing tests that I have looked at we are missing other features / have bugs elsewhere. As a note for the review: The functions in the `impl Context` block in `boa_engine/src/environments/runtime.rs` are mostly copied / moved from the existing functions. The only change there should be the addition of the object environment logic. They had to be moved to `Context` because of borrow semantics.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
with and object environmentswith and object environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
withstatement parsing, ast node, compilation and excution.withstatement excution.The implementation of object environments can probably be optimized further by using more compile-time information about when object environments can exist. Maybe there could also be a separate environment stack for object environments to reduce the filtering and iteration that is needed with the current implementation.
This does not fix all tests in the
test/language/statements/withsuite yet. But for most failing tests that I have looked at we are missing other features / have bugs elsewhere.As a note for the review:
The functions in the
impl Contextblock inboa_engine/src/environments/runtime.rsare mostly copied / moved from the existing functions. The only change there should be the addition of the object environment logic. They had to be moved toContextbecause of borrow semantics.