[Merged by Bors] - Shrink objects by using ThinVecs
#2752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad,
jedel1043 and
nekevss
Test262 conformance changes
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
The fields like `[[PrivateElements]]` are hardly used but they occupy `24` bytes (on 64-bit arch.) the `ThinVec` type stores the `len` and `cap` right before the elements (like our `JsString` implementation) and only a pointer is kept (if not used it does not allocate!), was going to use this in #2723 , since it uses a `Vec` as a dense storage, but the PR is already too big. It changes the following: - Shrink object from `328` to `288` bytes (40 bytes reduction) - Add the `thin_vec` lightweight crate (single file)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ThinVecsThinVecs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields like
[[PrivateElements]]are hardly used but they occupy24bytes (on 64-bit arch.) theThinVectype stores thelenandcapright before the elements (like ourJsStringimplementation) and only a pointer is kept (if not used it does not allocate!), was going to use this in #2723 , since it uses aVecas a dense storage, but the PR is already too big.It changes the following:
328to288bytes (40 bytes reduction)thin_veclightweight crate (single file)