Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement JsPromise wrapper #2758

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Implement JsPromise wrapper #2758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d725ae
Implement `JsPromise` wrapper
jedel1043 Mar 23, 2023
7cd9930
Reword docs
jedel1043 Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions boa_engine/src/builtins/async_generator/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,7 @@ impl AsyncGenerator {

// 2. Let promiseCapability be ! NewPromiseCapability(%Promise%).
let promise_capability = PromiseCapability::new(
&context
.intrinsics()
.constructors()
.promise()
.constructor()
.into(),
&context.intrinsics().constructors().promise().constructor(),
context,
)
.expect("cannot fail with promise constructor");
Expand Down Expand Up @@ -207,12 +202,7 @@ impl AsyncGenerator {

// 2. Let promiseCapability be ! NewPromiseCapability(%Promise%).
let promise_capability = PromiseCapability::new(
&context
.intrinsics()
.constructors()
.promise()
.constructor()
.into(),
&context.intrinsics().constructors().promise().constructor(),
context,
)
.expect("cannot fail with promise constructor");
Expand Down Expand Up @@ -295,12 +285,7 @@ impl AsyncGenerator {

// 2. Let promiseCapability be ! NewPromiseCapability(%Promise%).
let promise_capability = PromiseCapability::new(
&context
.intrinsics()
.constructors()
.promise()
.constructor()
.into(),
&context.intrinsics().constructors().promise().constructor(),
context,
)
.expect("cannot fail with promise constructor");
Expand Down Expand Up @@ -557,7 +542,7 @@ impl AsyncGenerator {

// 6. Let promise be ? PromiseResolve(%Promise%, completion.[[Value]]).
let promise_completion = Promise::promise_resolve(
context.intrinsics().constructors().promise().constructor(),
&context.intrinsics().constructors().promise().constructor(),
value,
context,
);
Expand Down Expand Up @@ -653,8 +638,8 @@ impl AsyncGenerator {
// 11. Perform PerformPromiseThen(promise, onFulfilled, onRejected).
Promise::perform_promise_then(
&promise,
&on_fulfilled.into(),
&on_rejected.into(),
Some(on_fulfilled),
Some(on_rejected),
None,
context,
);
Expand Down
27 changes: 6 additions & 21 deletions boa_engine/src/builtins/iterable/async_from_sync_iterator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,7 @@ impl AsyncFromSyncIterator {

// 3. Let promiseCapability be ! NewPromiseCapability(%Promise%).
let promise_capability = PromiseCapability::new(
&context
.intrinsics()
.constructors()
.promise()
.constructor()
.into(),
&context.intrinsics().constructors().promise().constructor(),
context,
)
.expect("cannot fail with promise constructor");
Expand Down Expand Up @@ -145,12 +140,7 @@ impl AsyncFromSyncIterator {

// 3. Let promiseCapability be ! NewPromiseCapability(%Promise%).
let promise_capability = PromiseCapability::new(
&context
.intrinsics()
.constructors()
.promise()
.constructor()
.into(),
&context.intrinsics().constructors().promise().constructor(),
context,
)
.expect("cannot fail with promise constructor");
Expand Down Expand Up @@ -243,12 +233,7 @@ impl AsyncFromSyncIterator {

// 3. Let promiseCapability be ! NewPromiseCapability(%Promise%).
let promise_capability = PromiseCapability::new(
&context
.intrinsics()
.constructors()
.promise()
.constructor()
.into(),
&context.intrinsics().constructors().promise().constructor(),
context,
)
.expect("cannot fail with promise constructor");
Expand Down Expand Up @@ -348,7 +333,7 @@ impl AsyncFromSyncIterator {

// 6. Let valueWrapper be Completion(PromiseResolve(%Promise%, value)).
let value_wrapper = Promise::promise_resolve(
context.intrinsics().constructors().promise().constructor(),
&context.intrinsics().constructors().promise().constructor(),
value,
context,
);
Expand Down Expand Up @@ -381,8 +366,8 @@ impl AsyncFromSyncIterator {
// 11. Perform PerformPromiseThen(valueWrapper, onFulfilled, undefined, promiseCapability).
Promise::perform_promise_then(
&value_wrapper,
&on_fulfilled.into(),
&JsValue::Undefined,
Some(on_fulfilled),
None,
Some(promise_capability.clone()),
context,
);
Expand Down
Loading