Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix String.prototype.replace() order of ToString execution #2799

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

Fix order of ToString execution, there are 3 failing tests on .replace() but they seem to be regex related

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 10, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 10, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,343 94,343 0
Passed 71,163 71,167 +4
Ignored 17,386 17,386 0
Failed 5,794 5,790 -4
Panics 0 0 0
Conformance 75.43% 75.43% +0.00%
Fixed tests (4):
test/built-ins/String/prototype/replace/replaceValue-evaluation-order-regexp-object.js [strict mode] (previously Failed)
test/built-ins/String/prototype/replace/replaceValue-evaluation-order-regexp-object.js (previously Failed)
test/built-ins/String/prototype/replace/replaceValue-evaluation-order.js [strict mode] (previously Failed)
test/built-ins/String/prototype/replace/replaceValue-evaluation-order.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #2799 (6597f07) into main (34d6b93) will decrease coverage by 0.01%.
The diff coverage is 70.96%.

@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
- Coverage   50.57%   50.56%   -0.01%     
==========================================
  Files         415      415              
  Lines       41207    41206       -1     
==========================================
- Hits        20841    20837       -4     
- Misses      20366    20369       +3     
Impacted Files Coverage Δ
boa_engine/src/builtins/string/mod.rs 62.98% <70.96%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix and also nice optimization with the enum.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Razican
Copy link
Member

Razican commented Apr 10, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 10, 2023
Fix order of `ToString` execution, there are 3 failing tests on `.replace()` but they seem to be regex related
@bors
Copy link

bors bot commented Apr 10, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix String.prototype.replace() order of ToString execution [Merged by Bors] - Fix String.prototype.replace() order of ToString execution Apr 10, 2023
@bors bors bot closed this Apr 10, 2023
@bors bors bot deleted the fix/string-replace-method branch April 10, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants