[Merged by Bors] - Fix sync generator yield expressions #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
Test262 conformance changes
Fixed tests (12):Broken tests (2): |
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
jedel1043 and
nekevss
Codecov Report
@@ Coverage Diff @@
## main #2838 +/- ##
=======================================
Coverage 51.39% 51.39%
=======================================
Files 417 417
Lines 41328 41328
=======================================
+ Hits 21239 21241 +2
+ Misses 20089 20087 -2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
approved these changes
Apr 18, 2023
raskad
force-pushed
the
fix-sync-generator-yield
branch
from
d645076
to
dadda0c
Compare
|
Nice work! I like the changes overall, any idea why |
I did not look into it too much, because I'm currently working on a fix for async generators and proper async generator |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
Depends on #2837. This Pull Request changes the following: - Fix the remaining `language/expressions/yield` tests. - Align the sync generator execution more to the spec. This breaks one async generator test. We can ignore that one as async generators are currently very broken. I will try to fix async generators next.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2837.
This Pull Request changes the following:
language/expressions/yieldtests.This breaks one async generator test. We can ignore that one as async generators are currently very broken. I will try to fix async generators next.