Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Create a unique PromiseCapability on each async function call #2846

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

This Pull Request changes the following:

  • Creates a new PromiseCapability after every async function call instead of sharing the same capability for all calls of the same async function.

@jedel1043 jedel1043 added execution Issues or PRs related to code execution Internal Category for changelog labels Apr 19, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Apr 19, 2023
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,591 94,591 0
Passed 73,161 73,165 +4
Ignored 17,530 17,530 0
Failed 3,900 3,896 -4
Panics 0 0 0
Conformance 77.34% 77.35% +0.00%
Fixed tests (4):
test/harness/asyncHelpers-throwsAsync-custom-typeerror.js [strict mode] (previously Failed)
test/harness/asyncHelpers-throwsAsync-custom-typeerror.js (previously Failed)
test/language/expressions/in/private-field-rhs-await-present.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-rhs-await-present.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #2846 (f4a2b74) into main (f97ad0d) will increase coverage by 0.00%.
The diff coverage is 51.66%.

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   50.92%   50.92%           
=======================================
  Files         419      419           
  Lines       41780    41776    -4     
=======================================
- Hits        21278    21276    -2     
+ Misses      20502    20500    -2     
Impacted Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 39.95% <ø> (ø)
boa_engine/src/vm/code_block.rs 60.87% <51.66%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! : )

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 21, 2023
This Pull Request changes the following:

- Creates a new `PromiseCapability` after every async function call instead of sharing the same capability for all calls of the same async function.
@bors
Copy link

bors bot commented Apr 21, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Create a unique PromiseCapability on each async function call [Merged by Bors] - Create a unique PromiseCapability on each async function call Apr 21, 2023
@bors bors bot closed this Apr 21, 2023
@bors bors bot deleted the unique-promise-caps branch April 21, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants