[Merged by Bors] - Fix setting properties inside with blocks

[jedel1043]

This preserves the semantics of the abstract operation Set on with blocks; setting non-writable properties on non-strict mode just silently fails.

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	94,591	94,591	0
Passed	71,670	71,671	+1
Ignored	17,686	17,686	0
Failed	5,235	5,234	-1
Panics	0	0	0
Conformance	75.77%	75.77%	+0.00%

Fixed tests (1):

test/built-ins/String/S15.5.5.1_A4_T1.js (previously Failed)

[codecov]

Codecov Report

Merging #2847 (66fab9c) into main (c87cf7c) will decrease coverage by 0.03%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #2847      +/-   ##
==========================================
- Coverage   51.38%   51.36%   -0.03%     
==========================================
  Files         417      417              
  Lines       41328    41356      +28     
==========================================
+ Hits        21238    21244       +6     
- Misses      20090    20112      +22     

Impacted Files	Coverage Δ
boa_engine/src/environments/runtime.rs	69.73% <0.00%> (ø)
boa_engine/src/vm/opcode/define/mod.rs	88.67% <100.00%> (+0.67%)	⬆️
boa_engine/src/vm/opcode/set/name.rs	68.29% <100.00%> (+3.42%)	⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[HalidOdat]

Good catch!

[Razican]

Thanks!

[Razican]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Build and Test (macos-latest)
• Build and Test (windows-latest)
• Coverage
• Misc