-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix for-of
expression parsing
#2882
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Something isn't working
parser
Issues surrounding the parser
labels
Apr 29, 2023
Test262 conformance changes
Fixed tests (6):
|
HalidOdat
force-pushed
the
fix/for-of-in-expression-parsing
branch
from
April 29, 2023 22:38
298dacd
to
a42fa02
Compare
Codecov Report
@@ Coverage Diff @@
## main #2882 +/- ##
=======================================
Coverage 51.24% 51.24%
=======================================
Files 427 427
Lines 42522 42525 +3
=======================================
+ Hits 21790 21794 +4
+ Misses 20732 20731 -1
|
HalidOdat
changed the title
Fix
Fix Apr 29, 2023
for-in/of
expression parsingfor-of
expression parsing
HalidOdat
force-pushed
the
fix/for-of-in-expression-parsing
branch
from
April 29, 2023 22:41
a42fa02
to
73740b0
Compare
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad,
jedel1043 and
nekevss
April 30, 2023 03:31
Razican
approved these changes
Apr 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
HalidOdat
force-pushed
the
fix/for-of-in-expression-parsing
branch
from
April 30, 2023 09:49
73740b0
to
fb0d02a
Compare
raskad
approved these changes
Apr 30, 2023
bors r+ |
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fix
[Merged by Bors] - Fix Apr 30, 2023
for-of
expression parsingfor-of
expression parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes parsing of expressions in for-of loops use
AssignmentExpression
expression parsing as defined in the spec.