Added unit tests for boa_ast::Punctuator
#2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
test
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad,
jedel1043 and
nekevss
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2884 +/- ##
==========================================
+ Coverage 51.24% 51.59% +0.35%
==========================================
Files 427 427
Lines 42522 42625 +103
==========================================
+ Hits 21790 21993 +203
+ Misses 20732 20632 -100
|
Razican
commented
Apr 30, 2023
| @@ -177,6 +177,7 @@ impl Punctuator { | |||
| Self::Mul => Some(BinaryOp::Arithmetic(ArithmeticOp::Mul)), | |||
| Self::Div => Some(BinaryOp::Arithmetic(ArithmeticOp::Div)), | |||
| Self::Mod => Some(BinaryOp::Arithmetic(ArithmeticOp::Mod)), | |||
| Self::Exp => Some(BinaryOp::Arithmetic(ArithmeticOp::Exp)), | |||
There was a problem hiding this comment.
This was somehow missing before, but it doesn't seem to fix any new test.
|
Prefix removed :) |
HalidOdat
approved these changes
May 4, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #2883, which adds more tests for
boa_ast::Punctuator.