[Merged by Bors] - Improve debug output of JsNativeError and Realm
#2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
- Coverage 51.23% 51.23% -0.01%
==========================================
Files 427 427
Lines 42520 42557 +37
==========================================
+ Hits 21787 21805 +18
- Misses 20733 20752 +19
|
raskad
approved these changes
May 3, 2023
nekevss
approved these changes
May 3, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 3, 2023
It was reported that the `dbg!` output of native errors was too long. This PR skips printing the `Realm` of a `JsNativeError`. It also improves the `dbg!` output of `Realm` by skipping printing `Inner` and only printing the inner fields of `Inner`.
|
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
JsNativeError and RealmJsNativeError and Realm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that the
dbg!output of native errors was too long. This PR skips printing theRealmof aJsNativeError. It also improves thedbg!output ofRealmby skipping printingInnerand only printing the inner fields ofInner.