Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate declarative environment kinds #2921

Merged
merged 2 commits into from
May 10, 2023
Merged

Separate declarative environment kinds #2921

merged 2 commits into from
May 10, 2023

Conversation

jedel1043
Copy link
Member

This Pull Request separates declarative environments into kinds, which makes it easier to add more kinds in the future (spoiler: module environments).

@jedel1043 jedel1043 added execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. labels May 9, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone May 9, 2023
@jedel1043 jedel1043 requested a review from a team May 9, 2023 21:54
@github-actions
Copy link

github-actions bot commented May 9, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,657 94,657 0
Passed 73,889 73,889 0
Ignored 17,505 17,505 0
Failed 3,263 3,263 0
Panics 0 0 0
Conformance 78.06% 78.06% 0.00%

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #2921 (8926dba) into main (85a253e) will increase coverage by 0.08%.
The diff coverage is 87.16%.

@@            Coverage Diff             @@
##             main    #2921      +/-   ##
==========================================
+ Coverage   51.98%   52.06%   +0.08%     
==========================================
  Files         431      435       +4     
  Lines       43647    43689      +42     
==========================================
+ Hits        22690    22748      +58     
+ Misses      20957    20941      -16     
Impacted Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 39.74% <ø> (ø)
boa_engine/src/builtins/generator/mod.rs 31.84% <ø> (ø)
boa_engine/src/vm/opcode/push/new_target.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/function/arguments.rs 96.61% <50.00%> (+0.84%) ⬆️
boa_engine/src/vm/opcode/environment/mod.rs 53.53% <64.00%> (+2.35%) ⬆️
...e/src/environments/runtime/declarative/function.rs 77.77% <77.77%> (ø)
boa_engine/src/vm/code_block.rs 56.57% <88.23%> (ø)
boa_engine/src/environments/runtime/mod.rs 79.62% <92.75%> (ø)
...engine/src/environments/runtime/declarative/mod.rs 93.67% <93.67%> (ø)
boa_engine/src/builtins/eval/mod.rs 64.21% <100.00%> (-1.79%) ⬇️
... and 5 more

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice refactor! This makes the runtime environment code much more readable. Great work.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! :)

@jedel1043 jedel1043 added this pull request to the merge queue May 10, 2023
Merged via the queue into main with commit 71ea4d2 May 10, 2023
@jedel1043 jedel1043 deleted the declarative-kinds branch May 11, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants