Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused lint allows #2968

Merged
merged 1 commit into from
May 27, 2023
Merged

Remove unused lint allows #2968

merged 1 commit into from
May 27, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented May 27, 2023

This Pull Request changes the following:

  • Remove some unused lint allows
  • Move some lint allows to more specific items

@raskad raskad added the Internal Category for changelog label May 27, 2023
@raskad raskad added this to the v0.17.0 milestone May 27, 2023
@raskad raskad requested a review from a team May 27, 2023 14:51
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,990 93,990 0
Passed 74,620 74,620 0
Ignored 17,622 17,622 0
Failed 1,748 1,748 0
Panics 0 0 0
Conformance 79.39% 79.39% 0.00%

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #2968 (f864b8e) into main (8486c28) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2968      +/-   ##
==========================================
- Coverage   50.02%   50.02%   -0.01%     
==========================================
  Files         446      446              
  Lines       45896    45895       -1     
==========================================
- Hits        22960    22959       -1     
  Misses      22936    22936              
Impacted Files Coverage Δ
boa_engine/src/builtins/map/ordered_map.rs 76.92% <ø> (ø)
boa_engine/src/builtins/string/mod.rs 57.11% <ø> (ø)
boa_engine/src/bytecompiler/mod.rs 66.08% <ø> (ø)
boa_engine/src/object/builtins/jspromise.rs 0.00% <ø> (ø)
boa_engine/src/object/internal_methods/string.rs 36.36% <ø> (ø)
boa_engine/src/realm.rs 73.80% <ø> (ø)
boa_engine/src/string/mod.rs 74.44% <ø> (ø)
boa_parser/src/lexer/cursor.rs 87.03% <ø> (ø)
boa_parser/src/parser/cursor/mod.rs 84.70% <ø> (ø)
boa_parser/src/parser/mod.rs 41.84% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@raskad raskad added this pull request to the merge queue May 27, 2023
Merged via the queue into main with commit 4ea80f4 May 27, 2023
@raskad raskad deleted the remove-unused-allows branch May 27, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants