Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly initialize functions inside modules #2993

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

jedel1043
Copy link
Member

Small fix that ensures bindings inside functions are correctly resolved to outer functions.

@jedel1043 jedel1043 added bug Something isn't working execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. labels Jun 3, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jun 3, 2023
@jedel1043 jedel1043 requested a review from a team June 3, 2023 07:03
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,118 94,118 0
Passed 74,620 74,620 0
Ignored 17,750 17,750 0
Failed 1,748 1,748 0
Panics 0 0 0
Conformance 79.28% 79.28% 0.00%

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #2993 (37bba53) into main (6b595e7) will decrease coverage by 0.02%.
The diff coverage is 23.80%.

@@            Coverage Diff             @@
##             main    #2993      +/-   ##
==========================================
- Coverage   50.23%   50.22%   -0.02%     
==========================================
  Files         446      446              
  Lines       46000    46020      +20     
==========================================
+ Hits        23110    23114       +4     
- Misses      22890    22906      +16     
Impacted Files Coverage Δ
boa_engine/src/module/source.rs 0.00% <0.00%> (ø)
boa_ast/src/operations.rs 75.13% <28.57%> (+0.16%) ⬆️
boa_engine/src/bytecompiler/declarations.rs 55.88% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@HalidOdat HalidOdat added this pull request to the merge queue Jun 3, 2023
Merged via the queue into main with commit 2fa9c65 Jun 3, 2023
@raskad raskad deleted the fn-module-init branch June 3, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants