Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in optional expressions with private identifiers #2995

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Fix panic in optional expressions with private identifiers #2995

merged 1 commit into from
Jun 4, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 3, 2023 •
edited
Loading

This Pull Request changes the following:

  • Fix panic in optional expressions with private identifiers

Credit to @addisoncrump and their work on our fuzzers which found this panic :)

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Jun 3, 2023
@raskad raskad added this to the v0.17.0 milestone Jun 3, 2023
@raskad raskad requested a review from a team June 3, 2023 22:47
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,118 94,118 0
Passed 74,620 74,620 0
Ignored 17,750 17,750 0
Failed 1,748 1,748 0
Panics 0 0 0
Conformance 79.28% 79.28% 0.00%

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #2995 (4ac2cc4) into main (ee97198) will increase coverage by 0.05%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #2995      +/-   ##
==========================================
+ Coverage   50.15%   50.20%   +0.05%     
==========================================
  Files         446      446              
  Lines       46030    46042      +12     
==========================================
+ Hits        23087    23117      +30     
+ Misses      22943    22925      -18
Impacted Files Coverage Δ
boa_ast/src/operations.rs 75.68% <91.66%> (+0.54%) ⬆️

... and 4 files with indirect coverage changes

Razican
Razican approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

HalidOdat
HalidOdat approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

@HalidOdat HalidOdat added this pull request to the merge queue Jun 4, 2023
Merged via the queue into main with commit 940529a Jun 4, 2023
@HalidOdat HalidOdat deleted the fix-private-name-optional-panic branch June 4, 2023 11:43
Razican pushed a commit that referenced this pull request Jun 26, 2023
@raskad @Razican
Fix panic in optional expressions with private identifiers (#2995)
b5c8748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @Razican @HalidOdat