Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in constructor call #3001

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix panic in constructor call #3001

merged 1 commit into from
Jun 6, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 6, 2023

This Pull Request changes the following:

  • Fix a bug in the constructor execution that leads to a panic when an arguments object is needed. In contrast to the call execution the wrong environment is being pushed.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Jun 6, 2023
@raskad raskad added this to the v0.17.0 milestone Jun 6, 2023
@raskad raskad requested a review from a team June 6, 2023 00:03
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,108 94,108 0
Passed 74,620 74,620 0
Ignored 17,740 17,740 0
Failed 1,748 1,748 0
Panics 0 0 0
Conformance 79.29% 79.29% 0.00%

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #3001 (656bc22) into main (940529a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3001      +/-   ##
==========================================
+ Coverage   50.20%   50.22%   +0.01%     
==========================================
  Files         446      446              
  Lines       46042    46048       +6     
==========================================
+ Hits        23117    23127      +10     
+ Misses      22925    22921       -4     
Impacted Files Coverage Δ
boa_engine/src/vm/code_block.rs 57.75% <100.00%> (+1.44%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Razican Razican requested a review from a team June 6, 2023 04:25
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix :)

@jedel1043 jedel1043 added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit c9a7bdc Jun 6, 2023
@jedel1043 jedel1043 deleted the fix-contructor-panic branch June 6, 2023 06:06
Razican pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants