Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class constructor return value #3028

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 11, 2023

This Pull Request changes the following:

  • Adjust compilation of class constructors to always leave the stack with one return value.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Jun 11, 2023
@raskad raskad added this to the v0.17.0 milestone Jun 11, 2023
@raskad raskad requested a review from a team June 11, 2023 23:19
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,108 94,108 0
Passed 74,648 74,654 +6
Ignored 17,740 17,740 0
Failed 1,720 1,714 -6
Panics 0 0 0
Conformance 79.32% 79.33% +0.01%
Fixed tests (6):
test/language/statements/class/poisoned-underscore-proto.js [strict mode] (previously Failed)
test/language/statements/class/poisoned-underscore-proto.js (previously Failed)
test/language/expressions/super/call-poisoned-underscore-proto.js [strict mode] (previously Failed)
test/language/expressions/super/call-poisoned-underscore-proto.js (previously Failed)
test/language/expressions/class/poisoned-underscore-proto.js [strict mode] (previously Failed)
test/language/expressions/class/poisoned-underscore-proto.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #3028 (79dc4f3) into main (423f099) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3028      +/-   ##
==========================================
- Coverage   50.56%   50.56%   -0.01%     
==========================================
  Files         446      446              
  Lines       45981    45983       +2     
==========================================
  Hits        23252    23252              
- Misses      22729    22731       +2     
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/class.rs 15.52% <33.33%> (-0.09%) ⬇️

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :)

@Razican Razican added this pull request to the merge queue Jun 12, 2023
Merged via the queue into main with commit 827c055 Jun 12, 2023
@raskad raskad deleted the fix-class-constructor-return-value branch June 12, 2023 19:07
Razican pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants