Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RefCell of CompileTimeEnvironments to field bindings #3108

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Jul 4, 2023

All fields except the bindings field are not mutated after CompileTimeEnvironment creation. It moves the RefCell to bindings field, this cleans the methods callsites.

All field except the `bindings` field are mutated after `CompileTimeEnvironment`
creation. It moves the `RefCell` to `bindings` field, this cleans the methods callsites.
@HalidOdat HalidOdat added the Internal Category for changelog label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,842 94,842 0
Passed 74,691 74,691 0
Ignored 18,812 18,812 0
Failed 1,339 1,339 0
Panics 0 0 0
Conformance 78.75% 78.75% 0.00%

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3108 (d9bd825) into main (9b1f2f4) will increase coverage by 0.24%.
The diff coverage is 89.55%.

@@            Coverage Diff             @@
##             main    #3108      +/-   ##
==========================================
+ Coverage   50.42%   50.66%   +0.24%     
==========================================
  Files         444      444              
  Lines       45877    42596    -3281     
==========================================
- Hits        23132    21580    -1552     
+ Misses      22745    21016    -1729     
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/function.rs 90.62% <ø> (ø)
...ine/src/environments/runtime/declarative/module.rs 0.00% <ø> (ø)
boa_engine/src/module/source.rs 0.00% <0.00%> (ø)
...ne/src/object/internal_methods/module_namespace.rs 0.00% <ø> (ø)
boa_engine/src/vm/code_block.rs 59.84% <ø> (-1.17%) ⬇️
boa_engine/src/bytecompiler/declarations.rs 51.52% <66.66%> (-3.80%) ⬇️
boa_engine/src/environments/runtime/mod.rs 80.86% <80.00%> (-0.21%) ⬇️
boa_engine/src/bytecompiler/env.rs 94.59% <88.88%> (+1.26%) ⬆️
boa_engine/src/environments/compile.rs 86.50% <94.73%> (+1.65%) ⬆️
boa_engine/src/bytecompiler/expression/assign.rs 38.00% <100.00%> (ø)
... and 4 more

... and 183 files with indirect coverage changes

@HalidOdat HalidOdat requested a review from a team July 4, 2023 17:52
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Razican Razican added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit 40f33d8 Jul 9, 2023
@HalidOdat HalidOdat deleted the move-refcell-to-inner-field branch July 9, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants