Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Array.prototype.find* and TypedArray variants to use FindViaPredicate #3134

Merged
merged 3 commits into from
Jul 13, 2023

Remove duplicate callable check, simplify returns

fd1af53
Select commit
Loading
Failed to load commit list.
Merged

Refactor Array.prototype.find* and TypedArray variants to use FindViaPredicate #3134

Remove duplicate callable check, simplify returns
fd1af53
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Jul 12, 2023 in 0s

50.68% (+0.03%) compared to fe9c8d9

View this Pull Request on Codecov

50.68% (+0.03%) compared to fe9c8d9

Details

Codecov Report

Merging #3134 (fd1af53) into main (fe9c8d9) will increase coverage by 0.03%.
The diff coverage is 45.58%.

@@            Coverage Diff             @@
##             main    #3134      +/-   ##
==========================================
+ Coverage   50.65%   50.68%   +0.03%     
==========================================
  Files         444      444              
  Lines       42661    42651      -10     
==========================================
+ Hits        21608    21617       +9     
+ Misses      21053    21034      -19
Impacted Files Coverage Δ
boa_engine/src/builtins/typed_array/mod.rs 7.53% <5.00%> (+0.05%) ⬆️
boa_engine/src/builtins/array/mod.rs 77.13% <62.50%> (+0.81%) ⬆️

... and 2 files with indirect coverage changes

View more details on Codecov