Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypedArrayConstructors tests #3171

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix TypedArrayConstructors tests #3171

merged 1 commit into from
Jul 26, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Jul 25, 2023

This Pull Request fixes all remaining TypedArrayConstructors tests.

It changes the following:

  • Fix typo in TypedArray constructor.
  • Update the spec and code for some TypedArray and ArrayBuffer creation functions.
  • Add explicit early drops to burrowed Gcs in TypedArray methods where needed.
  • Fix logic errors in integer-indexed exotic object methods.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jul 25, 2023
@raskad raskad added this to the v0.18.0 milestone Jul 25, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,260 95,260 0
Passed 74,820 74,910 +90
Ignored 19,230 19,230 0
Failed 1,210 1,120 -90
Panics 0 0 0
Conformance 78.54% 78.64% +0.09%
Fixed tests (90): 
test/built-ins/TypedArrayConstructors/internals/HasProperty/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/key-is-lower-than-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/key-is-lower-than-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/BigInt/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/BigInt/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/BigInt/key-is-lower-than-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/BigInt/key-is-lower-than-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/key-is-out-of-bounds.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/key-is-out-of-bounds.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/BigInt/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/BigInt/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/BigInt/key-is-out-of-bounds.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/BigInt/key-is-out-of-bounds.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-numeric-index-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-numeric-index-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/detached-buffer-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/detached-buffer-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-numericindex-desc-not-writable-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-numericindex-desc-not-writable-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-lower-than-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-lower-than-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-numericindex-desc-not-enumerable-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-numericindex-desc-not-enumerable-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/detached-buffer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/detached-buffer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/detached-buffer-throws-realm.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/detached-buffer-throws-realm.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-numeric-index-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-numeric-index-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-throws-realm.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-throws-realm.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/key-is-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/key-is-minus-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/tonumber-value-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/tonumber-value-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/key-is-out-of-bounds.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/key-is-out-of-bounds.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/detached-buffer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/detached-buffer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/key-is-not-integer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/key-is-not-integer.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/key-is-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/key-is-minus-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/tonumber-value-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/tonumber-value-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/key-is-out-of-bounds.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/key-is-out-of-bounds.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/no-species.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/no-species.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/buffer-arg/length-to-number-detachbuffer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/buffer-arg/length-to-number-detachbuffer.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/as-generator-iterable-returns.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/as-generator-iterable-returns.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/iterator-not-callable-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/iterator-not-callable-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/iterating-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/iterating-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/iterator-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors/object-arg/iterator-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/length-to-number-detachbuffer.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/length-to-number-detachbuffer.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/as-generator-iterable-returns.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/as-generator-iterable-returns.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/iterator-not-callable-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/iterator-not-callable-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/iterating-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/iterating-throws.js (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/iterator-throws.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/ctors-bigint/object-arg/iterator-throws.js (previously Failed)

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #3171 (e69050a) into main (3422bcc) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3171      +/-   ##
==========================================
- Coverage   50.61%   50.53%   -0.09%     
==========================================
  Files         444      444              
  Lines       42696    42767      +71     
==========================================
  Hits        21612    21612              
- Misses      21084    21155      +71
Files Changed Coverage Δ
boa_engine/src/builtins/array_buffer/mod.rs 9.92% <0.00%> (-0.33%) ⬇️
boa_engine/src/builtins/typed_array/mod.rs 7.30% <0.00%> (-0.15%) ⬇️
...ine/src/object/internal_methods/integer_indexed.rs 0.00% <0.00%> (ø)

@raskad raskad requested a review from a team July 25, 2023 02:22
HalidOdat
HalidOdat approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some small comments :)

boa_engine/src/builtins/array_buffer/mod.rs Show resolved Hide resolved
boa_engine/src/builtins/typed_array/mod.rs Show resolved Hide resolved
@HalidOdat HalidOdat requested a review from a team July 25, 2023 05:08
jedel1043
jedel1043 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@HalidOdat HalidOdat added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 33e8c51 Jul 26, 2023
9 checks passed
@raskad raskad deleted the typed-array-fixes branch July 30, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @HalidOdat @jedel1043