Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early errors for LexicalDeclaration #3207

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 10, 2023

This Pull Request fixes/closes #3206.

It changes the following:

  • Add early errors for LexicalDeclaration

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Aug 10, 2023
@raskad raskad added this to the v0.18.0 milestone Aug 10, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,282 95,282 0
Passed 75,036 75,036 0
Ignored 19,220 19,220 0
Failed 1,026 1,026 0
Panics 0 0 0
Conformance 78.75% 78.75% 0.00%

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #3207 (f58311d) into main (3a6715a) will increase coverage by 0.01%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main    #3207      +/-   ##
==========================================
+ Coverage   50.43%   50.44%   +0.01%     
==========================================
  Files         436      436              
  Lines       42531    42542      +11     
==========================================
+ Hits        21450    21461      +11     
  Misses      21081    21081              
Files Changed Coverage Δ
...parser/src/parser/statement/declaration/lexical.rs 70.50% <72.72%> (+2.53%) ⬆️

@raskad raskad requested a review from a team August 10, 2023 02:24
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Razican Razican added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 22b014d Aug 10, 2023
9 checks passed
@HalidOdat HalidOdat deleted the fix-lexical-declaration-early-errors branch August 10, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redeclaration of a const identifier in a for-loop initialiser leads to panic
3 participants