Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Gc::new_cyclic #3292

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Implement Gc::new_cyclic #3292

merged 2 commits into from
Sep 21, 2023

Conversation

jedel1043
Copy link
Member

This is just the corresponding replacement for the Rc::new_cyclic method, which showed to be useful while I was trying to improve some patterns in our modules implementation.

@jedel1043 jedel1043 added enhancement New feature or request API gc Issue related to garbage collection labels Sep 20, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 20, 2023
@jedel1043 jedel1043 requested a review from a team September 20, 2023 22:51
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,084 75,084 0
Ignored 19,494 19,494 0
Failed 996 996 0
Panics 0 0 0
Conformance 78.56% 78.56% 0.00%

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 6.66% and project coverage change: -0.02% ⚠️

Comparison is base (8a78061) 50.31% compared to head (2dc5f78) 50.30%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
- Coverage   50.31%   50.30%   -0.02%     
==========================================
  Files         436      436              
  Lines       42604    42618      +14     
==========================================
  Hits        21438    21438              
- Misses      21166    21180      +14     
Files Changed Coverage Δ
boa_gc/src/internals/ephemeron_box.rs 78.08% <0.00%> (-8.29%) ⬇️
boa_gc/src/pointers/gc.rs 54.68% <0.00%> (-4.64%) ⬇️
boa_gc/src/pointers/weak.rs 42.10% <0.00%> (-4.96%) ⬇️
boa_gc/src/pointers/ephemeron.rs 93.10% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat HalidOdat requested a review from a team September 21, 2023 13:56
@raskad raskad added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 20971e4 Sep 21, 2023
9 checks passed
@jedel1043 jedel1043 deleted the cyclic-gc branch September 21, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request gc Issue related to garbage collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants