Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static class element evaluation order #3327

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 30, 2023

This Pull Request changes the following:

  • Fix the evaluation oder of static class fields and static class blocks.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Sep 30, 2023
@raskad raskad added this to the v0.18.0 milestone Sep 30, 2023
@github-actions
Copy link

github-actions bot commented Sep 30, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,201 75,205 +4
Ignored 19,482 19,482 0
Failed 891 887 -4
Panics 0 0 0
Conformance 78.68% 78.69% +0.00%
Fixed tests (4):
test/language/statements/class/elements/intercalated-static-non-static-computed-fields.js [strict mode] (previously Failed)
test/language/statements/class/elements/intercalated-static-non-static-computed-fields.js (previously Failed)
test/language/expressions/class/elements/intercalated-static-non-static-computed-fields.js [strict mode] (previously Failed)
test/language/expressions/class/elements/intercalated-static-non-static-computed-fields.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (705e0ce) 49.41% compared to head (6f515c0) 49.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
- Coverage   49.41%   49.40%   -0.01%     
==========================================
  Files         445      445              
  Lines       43898    43909      +11     
==========================================
+ Hits        21690    21692       +2     
- Misses      22208    22217       +9     
Files Coverage Δ
boa_engine/src/bytecompiler/class.rs 14.79% <10.52%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad requested a review from a team September 30, 2023 11:50
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch! Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team September 30, 2023 12:05
@raskad raskad force-pushed the class-field-execution-order branch from 5862732 to 6f515c0 Compare October 2, 2023 19:59
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix for a really subtle bug :)

@jedel1043 jedel1043 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 55466b0 Oct 3, 2023
14 checks passed
@raskad raskad deleted the class-field-execution-order branch October 3, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants