Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup get_option and calls to the function #3355

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

jedel1043
Copy link
Member

I saw that #3277 provided better error messages when an option is required, instead of our current method of returning a generic error when required == true. Seeing this, I think it's just better to move that check to the caller and handle the None case by either throwing or setting a default.

This also removes some type annotations that aren't required.

@jedel1043 jedel1043 added technical debt Internal Category for changelog labels Oct 5, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 5, 2023
@jedel1043 jedel1043 requested a review from a team October 5, 2023 06:14
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,273 75,273 0
Ignored 19,482 19,482 0
Failed 819 819 0
Panics 0 0 0
Conformance 78.76% 78.76% 0.00%

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (1dcd0e6) 49.53% compared to head (227d6d5) 49.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
+ Coverage   49.53%   49.54%   +0.01%     
==========================================
  Files         446      446              
  Lines       43722    43710      -12     
==========================================
- Hits        21659    21658       -1     
+ Misses      22063    22052      -11     
Files Coverage Δ
boa_engine/src/builtins/intl/locale/utils.rs 50.63% <0.00%> (ø)
boa_engine/src/builtins/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/intl/segmenter/mod.rs 10.52% <0.00%> (+0.21%) ⬆️
boa_engine/src/builtins/intl/list_format/mod.rs 6.74% <0.00%> (+0.08%) ⬆️
...oa_engine/src/builtins/intl/number_format/utils.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/intl/plural_rules/mod.rs 6.71% <0.00%> (+0.04%) ⬆️
boa_engine/src/builtins/intl/collator/mod.rs 7.24% <0.00%> (+0.10%) ⬆️
boa_engine/src/builtins/intl/locale/mod.rs 23.15% <0.00%> (+0.75%) ⬆️
boa_engine/src/builtins/intl/locale/options.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nekevss nekevss requested a review from a team October 5, 2023 15:51
@HalidOdat HalidOdat added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit c56a706 Oct 5, 2023
14 checks passed
@jedel1043 jedel1043 deleted the cleanup-get-option branch October 5, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants