Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check eval realm before call #3375

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Check eval realm before call #3375

merged 1 commit into from
Oct 11, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Oct 11, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Oct 11, 2023
@HalidOdat HalidOdat requested a review from a team October 11, 2023 19:09
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,340 75,341 +1
Ignored 19,482 19,482 0
Failed 752 751 -1
Panics 0 0 0
Conformance 78.83% 78.83% +0.00%
Fixed tests (1):
test/language/expressions/call/eval-realm-indirect.js (previously Failed)

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (72d2546) 49.49% compared to head (93a8cfb) 49.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
- Coverage   49.49%   49.49%   -0.01%     
==========================================
  Files         446      446              
  Lines       43646    43648       +2     
==========================================
  Hits        21603    21603              
- Misses      22043    22045       +2     
Files Coverage Δ
boa_engine/src/vm/opcode/call/mod.rs 24.06% <30.00%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@raskad raskad added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 8470214 Oct 11, 2023
14 checks passed
@HalidOdat HalidOdat deleted the fix/eval-invalid-realm branch October 11, 2023 20:06
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants