Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix var declaration for deleted binding locator #3387

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 15, 2023

This Pull Request changes the following:

  • Fix var declaration for deleted binding locator

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Oct 15, 2023
@raskad raskad added this to the v0.18.0 milestone Oct 15, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,687 75,688 +1
Ignored 19,160 19,160 0
Failed 762 761 -1
Panics 0 0 0
Conformance 79.16% 79.16% +0.00%
Fixed tests (1):
test/language/statements/variable/binding-resolution.js (previously Failed)

@raskad raskad requested a review from a team October 15, 2023 23:31
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dd05f53) 45.72% compared to head (216d5de) 45.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3387   +/-   ##
=======================================
  Coverage   45.72%   45.72%           
=======================================
  Files         482      482           
  Lines       49177    49180    +3     
=======================================
+ Hits        22485    22488    +3     
  Misses      26692    26692           
Files Coverage Δ
boa_engine/src/bytecompiler/mod.rs 66.92% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 requested a review from a team October 16, 2023 02:36
@HalidOdat HalidOdat added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 9030417 Oct 16, 2023
14 checks passed
@HalidOdat HalidOdat deleted the var-locator branch October 16, 2023 06:13
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants