Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a thread safe version of JsError #3398

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

jedel1043
Copy link
Member

This should make it easier to interface with anyhow and eyre.

@jedel1043 jedel1043 added enhancement New feature or request API labels Oct 19, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 19, 2023
@jedel1043 jedel1043 requested a review from a team October 19, 2023 08:48
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,690 75,690 0
Ignored 19,160 19,160 0
Failed 759 759 0
Panics 0 0 0
Conformance 79.17% 79.17% 0.00%

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (1d66836) 45.78% compared to head (a6c3cc8) 45.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3398      +/-   ##
==========================================
- Coverage   45.78%   45.72%   -0.06%     
==========================================
  Files         483      483              
  Lines       49349    49412      +63     
==========================================
  Hits        22594    22594              
- Misses      26755    26818      +63     
Files Coverage Δ
boa_engine/src/context/mod.rs 51.97% <ø> (ø)
boa_engine/src/error.rs 27.42% <0.00%> (-7.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit 3296f87 Oct 19, 2023
14 checks passed
@jedel1043 jedel1043 deleted the thread-safe-js-error branch October 19, 2023 22:59
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants