Fix compilation for targets without AtomicU64
#3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3399 +/- ##
========================================
Coverage 45.71% 45.72%
========================================
Files 482 483 +1
Lines 49182 49412 +230
========================================
+ Hits 22485 22594 +109
- Misses 26697 26818 +121
☔ View full report in Codecov by Sentry. |
Razican
reviewed
Oct 19, 2023
Razican
approved these changes
Oct 19, 2023
| )] | ||
|
|
||
| #[cfg(not(target_has_atomic = "ptr"))] |
There was a problem hiding this comment.
In the future we might want to create a symbol feature, that requires this, so that users in platforms without this option can have most of JS working :)
HalidOdat
reviewed
Oct 19, 2023
HalidOdat
approved these changes
Oct 20, 2023
sam-finch-tezos
pushed a commit
to trilitech/boa
that referenced
this pull request
Nov 29, 2023
* Fix compilation for targets without `AtomicU64` * Throw compilation error if `AtomicUsize` is not available * Apply review pt. 1 * Apply review pt. 2 * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2599
Also addresses the clippy lint that we had disabled temporarily.