Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameter environment creation to bytecode #3433

Merged
merged 1 commit into from
Nov 2, 2023

Move parameter environment creation to opcode

0c1a450
Select commit
Loading
Failed to load commit list.
Merged

Move parameter environment creation to bytecode #3433

Move parameter environment creation to opcode
0c1a450
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 2, 2023 in 0s

44.81% (-0.02%) compared to dca8457

View this Pull Request on Codecov

44.81% (-0.02%) compared to dca8457

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dca8457) 44.83% compared to head (0c1a450) 44.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3433      +/-   ##
==========================================
- Coverage   44.83%   44.81%   -0.02%     
==========================================
  Files         488      488              
  Lines       50390    50374      -16     
==========================================
- Hits        22590    22575      -15     
+ Misses      27800    27799       -1     
Files Coverage Δ
boa_engine/src/bytecompiler/declarations.rs 52.74% <100.00%> (ø)
boa_engine/src/object/internal_methods/function.rs 88.75% <ø> (-0.79%) ⬇️
boa_engine/src/vm/code_block.rs 24.85% <0.00%> (-0.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.