Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ordinary function [[ConstructorKind]] to CodeBlock #3439

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

HalidOdat
Copy link
Member

Since the [[ConstructorKind]] is known at compile time and it doesn't change, this moves it to CodeBlock in the CodeBlockFlags bitflags.

@HalidOdat HalidOdat added technical debt execution Issues or PRs related to code execution Internal Category for changelog labels Oct 30, 2023
@HalidOdat HalidOdat requested a review from a team October 30, 2023 09:15
@HalidOdat HalidOdat force-pushed the refactor/move-constructor-kind-to-codeblock branch from eaa7d8e to 4e9236f Compare October 30, 2023 09:27
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,978 75,978 0
Ignored 18,872 18,872 0
Failed 759 759 0
Panics 0 0 0
Conformance 79.47% 79.47% 0.00%

@HalidOdat HalidOdat force-pushed the refactor/move-constructor-kind-to-codeblock branch from 4e9236f to 5508af0 Compare October 30, 2023 09:39
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5e89c4e) 45.40% compared to head (67ad875) 45.39%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3439      +/-   ##
==========================================
- Coverage   45.40%   45.39%   -0.02%     
==========================================
  Files         483      483              
  Lines       49790    49787       -3     
==========================================
- Hits        22609    22602       -7     
- Misses      27181    27185       +4     
Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 38.34% <100.00%> (-1.30%) ⬇️
boa_engine/src/bytecompiler/class.rs 16.33% <100.00%> (+0.63%) ⬆️
boa_engine/src/vm/opcode/push/class/mod.rs 66.66% <ø> (-7.41%) ⬇️
boa_engine/src/vm/code_block.rs 28.16% <75.00%> (+0.54%) ⬆️
boa_engine/src/object/internal_methods/function.rs 91.08% <44.44%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HalidOdat HalidOdat marked this pull request as draft October 30, 2023 09:50
@HalidOdat HalidOdat force-pushed the refactor/move-constructor-kind-to-codeblock branch from 5508af0 to 67ad875 Compare October 30, 2023 09:53
@HalidOdat HalidOdat marked this pull request as ready for review October 30, 2023 11:16
@HalidOdat HalidOdat added this to the v0.18.0 milestone Oct 30, 2023
@raskad raskad requested a review from a team October 30, 2023 14:09
@raskad raskad added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 4b8ca76 Oct 30, 2023
14 checks passed
@HalidOdat HalidOdat deleted the refactor/move-constructor-kind-to-codeblock branch October 30, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution Internal Category for changelog technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants