Progress on Duration's round/total method updates #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
force-pushed
the
duration-round-total
branch
2 times, most recently
from
a0b6286
to
e3535d8
Compare
nekevss
force-pushed
the
duration-round-total
branch
from
e3535d8
to
5a05ca1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3451 +/- ##
==========================================
- Coverage 44.81% 44.67% -0.15%
==========================================
Files 488 488
Lines 50373 50513 +140
==========================================
- Hits 22576 22567 -9
- Misses 27797 27946 +149
☔ View full report in Codecov by Sentry. |
Test262 conformance changes
|
jedel1043
reviewed
Nov 6, 2023
jedel1043
reviewed
Nov 7, 2023
jedel1043
approved these changes
Nov 7, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
* Update round and total method * Apply review * Cargo fmt * validate rounding increment to u64
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
* Update round and total method * Apply review * Cargo fmt * validate rounding increment to u64
sam-finch-tezos
pushed a commit
to trilitech/boa
that referenced
this pull request
Nov 29, 2023
* Update round and total method * Apply review * Cargo fmt * validate rounding increment to u64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3443.
Just looking to merge more progress on some
Durationmethods. 😄Let me know what you think!