Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex.match spec and code #3462

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Update regex.match spec and code #3462

merged 1 commit into from
Nov 15, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Nov 12, 2023

It changes the following:

  • Update regex.match spec and code.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Nov 12, 2023
@raskad raskad added this to the v0.18.0 milestone Nov 12, 2023
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,518 76,524 +6
Ignored 18,132 18,132 0
Failed 959 953 -6
Panics 0 0 0
Conformance 80.03% 80.04% +0.01%
Fixed tests (6):
test/built-ins/RegExp/prototype/Symbol.match/get-flags-err.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/Symbol.match/get-flags-err.js (previously Failed)
test/built-ins/RegExp/prototype/Symbol.match/flags-tostring-error.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/Symbol.match/flags-tostring-error.js (previously Failed)
test/built-ins/RegExp/prototype/Symbol.match/get-unicode-error.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/Symbol.match/get-unicode-error.js (previously Failed)

@raskad raskad requested a review from a team November 12, 2023 17:07
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (89fd3be) 44.62% compared to head (1107e6a) 44.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
- Coverage   44.62%   44.62%   -0.01%     
==========================================
  Files         487      487              
  Lines       50541    50539       -2     
==========================================
- Hits        22554    22552       -2     
  Misses      27987    27987              
Files Coverage Δ
boa_engine/src/builtins/regexp/mod.rs 62.68% <73.91%> (-0.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 requested a review from a team November 15, 2023 02:35
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 4f0bb59 Nov 15, 2023
14 checks passed
@raskad raskad deleted the regex-match-fix branch December 5, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants