Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build out ZonedDateTime, TimeZone, and Instant #3497

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 4, 2023

Resubmission/Follow up to last PR that was closed with the updates rebased and moved to a different branch.

This mostly covers the basics of ZonedDateTime and TimeZone. The integration depends partially on the ISO8601 parsing migration as TimeZone needs to be parsed.

Related to #1804.

It changes the following:

  • Adds ZonedDateTime, TimeZone, and Instant to boa_temporal (not yet integrated completely integrated with boa_engine's builtins).
  • Adds balance methods to IsoTime and IsoDateTime.

Copy link

github-actions bot commented Dec 4, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,526 76,526 0
Ignored 18,132 18,132 0
Failed 951 951 0
Panics 0 0 0
Conformance 80.04% 80.04% 0.00%

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (055e8fe) 46.83% compared to head (0d909e0) 46.97%.

Files Patch % Lines
boa_temporal/src/zoneddatetime.rs 55.68% 39 Missing ⚠️
boa_temporal/src/tz.rs 32.00% 17 Missing ⚠️
boa_temporal/src/time.rs 0.00% 12 Missing ⚠️
boa_temporal/src/iso.rs 87.83% 9 Missing ⚠️
boa_engine/src/builtins/temporal/time_zone/mod.rs 0.00% 7 Missing ⚠️
boa_temporal/src/datetime.rs 64.70% 6 Missing ⚠️
boa_temporal/src/instant.rs 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
+ Coverage   46.83%   46.97%   +0.13%     
==========================================
  Files         493      496       +3     
  Lines       50077    50281     +204     
==========================================
+ Hits        23455    23620     +165     
- Misses      26622    26661      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss added this to the v0.18.0 milestone Dec 4, 2023
@nekevss nekevss added the builtins PRs and Issues related to builtins/intrinsics label Dec 4, 2023
@nekevss nekevss requested a review from a team December 4, 2023 04:39
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jedel1043 jedel1043 requested a review from a team December 5, 2023 15:48
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just needs a rebase.

@nekevss nekevss added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit d275557 Dec 6, 2023
14 checks passed
@raskad raskad deleted the temporal-tz-zdt-instant branch December 6, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants