feat(boa): in operator #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm waiting for #304 to land before proceeding with this, just to avoid more merge conflicts :) |
|
Wow, that's quite the change - no worries! |
|
#304 has been merged :D but now this gives a lot of merge conflicts. Could you rebase? |
For parsing: The expression! macro is extended to support a Keyword typed value in its op arguments. This followed the spec that some expressions are separated by Punctuators (like == etc.) but others are separated by Keywords (like this one, or others such as instanceof). This needed an implementation of PartialEq for Keyword and Punctuator in order to fix a type error caused by the repeated match guard. An as_binop method was added to Keyword to mimic the one in Punctuator. This may be better suited to a trait implementation of TryFrom for the BinOp enum, with implementations for TryFrom<Keyword> and TryFrom<Punctuator>. For interpreting: Some abstract operations were implemented that are used in the semantics of the operator in the spec. An as_object cast method was addedto ValueData in order to get a ref to that data as an object in order to use the Object methods on a ValueData value. Tests: Add unit tests to interpreter and parser for the new operator. Solves boa-dev#88
brian-gavin
force-pushed
the
feat/boa/in-operator
branch
from
ada5c94 to
b428acf
Compare
Razican
reviewed
Apr 29, 2020
HalidOdat
reviewed
May 1, 2020
Razican
reviewed
May 1, 2020
Add a test for props up the prototype chain. It is currently failing, but should be passing for this to be complete.
HalidOdat
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parsing:
The expression! macro is extended to support a Keyword typed value in its
op arguments. This followed the spec that some expressions are separated
by Punctuators (like == etc.) but others are separated by Keywords (like
this one, or others such as instanceof).
This needed an implementation of PartialEq for Keyword and Punctuator in
order to fix a type error caused by the repeated match guard.
An as_binop method was added to Keyword to mimic the one in Punctuator.
This may be better suited to a trait implementation of TryFrom for the
BinOp enum, with implementations for TryFrom and
TryFrom.
For interpreting:
Some abstract operations were implemented that are used in the semantics
of the operator in the spec.
An as_object cast method was addedto ValueData in order to get a ref to
that data as an object in order to use the Object methods on a
ValueData value.
Tests:
Add unit tests to interpreter and parser for the new operator.
Solves #88