Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boa_temporal structure changes and docs update #3504

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 6, 2023

This PR is primarily a proposal to change the structure of boa_temporal that ideally streamlines and organizes the crate a bit better than current.

It changes the following:

  • Moves the native Temporal objects into the components module and inline most of the native Temporal objects (excluding the time zone and calendar modules).
  • Builds out the docs a bit more or adds some clarity to the current docs

Let me know what you think or any thoughts! 😄

Copy link

github-actions bot commented Dec 6, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,526 76,526 0
Ignored 18,132 18,132 0
Failed 951 951 0
Panics 0 0 0
Conformance 80.04% 80.04% 0.00%

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d275557) 46.97% compared to head (789460e) 46.97%.

Files Patch % Lines
...oa_engine/src/builtins/temporal/calendar/object.rs 0.00% 2 Missing ⚠️
boa_temporal/src/components/zoneddatetime.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3504      +/-   ##
==========================================
- Coverage   46.97%   46.97%   -0.01%     
==========================================
  Files         496      496              
  Lines       50281    50279       -2     
==========================================
- Hits        23620    23618       -2     
  Misses      26661    26661              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss added this to the v0.18.0 milestone Dec 6, 2023
@nekevss nekevss added the documentation update documentation label Dec 6, 2023
@nekevss nekevss requested a review from a team December 6, 2023 04:49
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Looks good to me! :)

@jedel1043 jedel1043 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 4700436 Dec 6, 2023
14 checks passed
@jedel1043 jedel1043 deleted the temporal-components branch December 6, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants