Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid return value when closing an iterator #3567

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 5, 2024

This Pull Request changes the following:

  • Fix invalid return value when closing an iterator

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution waiting-on-review Waiting on reviews from the maintainers labels Jan 5, 2024
@raskad raskad added this to the v0.18.0 milestone Jan 5, 2024
@raskad raskad requested a review from a team January 5, 2024 11:53
Copy link

github-actions bot commented Jan 5, 2024

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,534 76,550 +16
Ignored 18,477 18,477 0
Failed 949 933 -16
Panics 0 0 0
Conformance 79.76% 79.77% +0.02%
Fixed tests (16):
test/language/expressions/assignment/dstr/array-elem-iter-rtrn-close.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-elem-iter-rtrn-close.js (previously Failed)
test/language/expressions/assignment/dstr/array-rest-iter-rtrn-close.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-rest-iter-rtrn-close.js (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-list-rtrn-close.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-list-rtrn-close.js (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-rest-rtrn-close.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-rest-rtrn-close.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-iter-rtrn-close.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-elem-iter-rtrn-close.js (previously Failed)
test/language/statements/for-of/dstr/array-rest-iter-rtrn-close.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-rest-iter-rtrn-close.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-list-rtrn-close.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-list-rtrn-close.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-rest-rtrn-close.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-rest-rtrn-close.js (previously Failed)

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35df2de) 47.42% compared to head (73078e0) 47.42%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3567   +/-   ##
=======================================
  Coverage   47.42%   47.42%           
=======================================
  Files         470      470           
  Lines       45690    45692    +2     
=======================================
+ Hits        21667    21669    +2     
  Misses      24023    24023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HalidOdat HalidOdat requested a review from a team January 5, 2024 13:51
@nekevss nekevss added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 6c5dfe0 Jan 5, 2024
14 checks passed
@raskad raskad deleted the fix-iter-close-return-value branch January 5, 2024 21:42
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants