Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocations from HostDefined::get_many_mut #3606

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

jedel1043
Copy link
Member

Small improvement to that method that avoids creating a Vec for indexing.

I also checked the generated assembly and it seems to skip some panics thanks to the const generic, so that's good.

@jedel1043 jedel1043 added enhancement New feature or request API labels Jan 23, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Jan 23, 2024
@jedel1043 jedel1043 requested a review from a team January 23, 2024 20:24
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,572 76,572 0
Ignored 18,477 18,477 0
Failed 911 911 0
Panics 0 0 0
Conformance 79.80% 79.80% 0.00%

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (37a9046) 47.35% compared to head (306cf79) 47.35%.

Files Patch % Lines
core/engine/src/host_defined.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3606   +/-   ##
=======================================
  Coverage   47.35%   47.35%           
=======================================
  Files         475      475           
  Lines       45919    45919           
=======================================
  Hits        21746    21746           
  Misses      24173    24173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad requested a review from a team January 23, 2024 21:16
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Looks good to me!

@HalidOdat HalidOdat added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 2ebcbab Jan 23, 2024
14 checks passed
@jedel1043 jedel1043 deleted the host-defined-improvements branch January 30, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants