Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping in RegExp.prototype.source #3619

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 27, 2024

This PR fixes the line terminator escaping in RegExp.prototype.source.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics waiting-on-review Waiting on reviews from the maintainers labels Jan 27, 2024
@raskad raskad added this to the v0.18.0 milestone Jan 27, 2024
@raskad raskad requested a review from a team January 27, 2024 16:38
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,594 76,596 +2
Ignored 18,477 18,477 0
Failed 889 887 -2
Panics 0 0 0
Conformance 79.82% 79.82% +0.00%
Fixed tests (2):
test/built-ins/RegExp/prototype/source/value-line-terminator.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/source/value-line-terminator.js (previously Failed)

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6be4296) 47.46% compared to head (97cd840) 47.46%.

Files Patch % Lines
core/engine/src/builtins/regexp/mod.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
- Coverage   47.46%   47.46%   -0.01%     
==========================================
  Files         475      475              
  Lines       46044    46046       +2     
==========================================
  Hits        21855    21855              
- Misses      24189    24191       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jedel1043 jedel1043 requested a review from a team January 27, 2024 16:49
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Jan 27, 2024
Merged via the queue into main with commit 8a1383a Jan 27, 2024
14 checks passed
@HalidOdat HalidOdat deleted the fix-regexp-source-escape branch January 27, 2024 21:52
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants