Added NPM publish workflow #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
nekevss
reviewed
Mar 7, 2024
jedel1043
requested changes
Mar 10, 2024
Comment on lines
+51
to
+57
| - name: Install Rust toolchain | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| target: wasm32-unknown-unknown | ||
| profile: minimal | ||
| override: true |
There was a problem hiding this comment.
Would prefer that we used Dtolnay's action, since actions-rs repos are unmaintained.
There was a problem hiding this comment.
I just noticed we are using the actions-rs actions everywhere in our codebase. Should we do this change separately, to migrate to the dtolnay's action?
There was a problem hiding this comment.
Yep, that would be preferable.
jedel1043
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a release workflow to publish NPM packages on each release in an autonomous way.