Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release binary striping #3727

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Add release binary striping #3727

merged 1 commit into from
Mar 10, 2024

Conversation

Razican
Copy link
Member

@Razican Razican commented Mar 9, 2024

Our binaries are currently quite big by default. Most of it (around 65%) is due to ICU data. But there are things we can do. Before going for more drastic solutions, such as abort panic, striping the binaries helps slightly.

In this case, striping helps only slightly:

  • boa binary: from 26 MB to 25 MB
  • boa_tester binary: from 27 MB to 25 MB

I did some further tests by adding panic = "abort", and this reduced sizes even further:

  • boa binary: 23MB
  • boa_tester binary: 24M

And we would lose panic unwinding, so I don't see too much benefit.

@Razican Razican added the enhancement New feature or request label Mar 9, 2024
@Razican Razican added this to the v0.18.1 milestone Mar 9, 2024
@Razican Razican requested a review from a team March 9, 2024 10:30
Copy link

github-actions bot commented Mar 9, 2024

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,754 42,754 0
Ignored 1,391 1,391 0
Failed 6,123 6,123 0
Panics 0 0 0
Conformance 85.05% 85.05% 0.00%

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this size decrease. Also agreed that removing unwinds is not worth the small size decrease.

@jasonwilliams jasonwilliams added the Internal Category for changelog label Mar 10, 2024
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Mar 10, 2024
Merged via the queue into main with commit 12b988d Mar 10, 2024
13 checks passed
@HalidOdat HalidOdat deleted the strip_binary branch March 10, 2024 22:40
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants