Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid syntax errors for allowed let as variable names #3743

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix invalid syntax errors for allowed let as variable names #3743

merged 1 commit into from
Mar 18, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 16, 2024

This allows let as a variable name in some more places.

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Mar 16, 2024
@raskad raskad added this to the v0.18.1 milestone Mar 16, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,773 42,774 +1
Ignored 1,391 1,391 0
Failed 6,104 6,103 -1
Panics 0 0 0
Conformance 85.09% 85.09% +0.00%
Fixed tests (1): 
test/language/statements/for/head-lhs-let.js (previously Failed)

@raskad raskad requested a review from a team March 16, 2024 01:31
HalidOdat
HalidOdat approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat changed the title Fix invalid syntex errors for allower let as variable names Fix invalid syntax errors for allowed let as variable names Mar 18, 2024
@HalidOdat HalidOdat requested a review from a team March 18, 2024 05:28
@jedel1043 jedel1043 added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 06b1c33 Mar 18, 2024
13 checks passed
@raskad raskad deleted the allow-valid-let-as-variable-name branch March 18, 2024 10:19
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @HalidOdat @jedel1043