Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run test262 on push #3774

Merged
merged 6 commits into from
Mar 31, 2024

Conversation

jasonwilliams
Copy link
Member

This PR relies on boa-dev/boa-dev.github.io#145 being merged first.
Essentially this stops adding test262 data to the gh-pages branch on each push to main.

Instead we will rely on the nightly which runs from the data repo instead, this will help remove a lot of data from this repository

@jasonwilliams jasonwilliams added github_actions Pull requests that update Github_actions code Internal Category for changelog labels Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.73%. Comparing base (6ddc2b4) to head (bb27e07).
Report is 108 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3774      +/-   ##
==========================================
+ Coverage   47.24%   47.73%   +0.48%     
==========================================
  Files         476      454      -22     
  Lines       46892    44747    -2145     
==========================================
- Hits        22154    21358     -796     
+ Misses      24738    23389    -1349     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043
Copy link
Member

Huh, I think there's an error on the modified yaml file.

test262.yml#L1
The workflow is not valid. .github/workflows/test262.yml: Unexpected tag '!steps.previous-comment.outputs.comment-id'

@jasonwilliams
Copy link
Member Author

Fixed the workflow but the boa_tester crate needs updating to not try and commit the results.

@jedel1043 jedel1043 disabled auto-merge March 30, 2024 15:45
@jedel1043 jedel1043 added this pull request to the merge queue Mar 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2024
@jasonwilliams jasonwilliams added this pull request to the merge queue Mar 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2024
@jasonwilliams jasonwilliams added this pull request to the merge queue Mar 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2024
@jasonwilliams jasonwilliams added this pull request to the merge queue Mar 31, 2024
Merged via the queue into boa-dev:main with commit e754df3 Mar 31, 2024
14 checks passed
@jasonwilliams jasonwilliams deleted the remove-test262-push branch July 15, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants