Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs.rs docs with all features enabled #3794

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Build docs.rs docs with all features enabled #3794

merged 1 commit into from
Apr 7, 2024

Conversation

jedel1043
Copy link
Member

Currently, the documentation of our crates on docs.rs doesn't show gated items. This PR solves that by adding the corresponding metadata on the Cargo.toml file.

@jedel1043 jedel1043 added enhancement New feature or request documentation update documentation labels Apr 6, 2024
@jedel1043 jedel1043 added this to the v0.18.1 milestone Apr 6, 2024
@jedel1043 jedel1043 requested a review from a team April 6, 2024 23:07
@raskad raskad requested a review from a team April 6, 2024 23:09
Copy link

github-actions bot commented Apr 6, 2024

Test262 conformance changes

Test result main count PR count difference
Total 50,731 50,731 0
Passed 42,971 42,971 0
Ignored 1,395 1,395 0
Failed 6,365 6,365 0
Panics 18 18 0
Conformance 84.70% 84.70% 0.00%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Apr 7, 2024
Merged via the queue into main with commit f2b9c83 Apr 7, 2024
13 checks passed
@HalidOdat HalidOdat deleted the better-docs branch April 7, 2024 00:44
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants