Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code of conduct based on Contributor Covenant 2.0 #384

Merged
merged 1 commit into from
May 13, 2020
Merged

Added code of conduct based on Contributor Covenant 2.0 #384

merged 1 commit into from
May 13, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented May 8, 2020

This PR adds a code of conduct to Boa. I just downloaded the Contributor Covenant 2.0 from https://www.contributor-covenant.org/ and added it to the repo.

There is only one thing that we must change before merging: the contact method that community members should use in case they would like to report a violation to the code. This is usually an email address of the person or group of people that are in charge of moderating the community in case someone violates the COC.

I think this is important enough so that every collaborator should approve the PR before merging it, so please read it and see if there is any improvement to be made, too.

Rendered

@Razican Razican added the discussion Issues needing more discussion label May 8, 2020
@Razican Razican added this to the v0.8.0 milestone May 8, 2020
@Razican Razican requested review from jasonwilliams and HalidOdat May 8, 2020 07:45
@github-actions
Copy link

github-actions bot commented May 8, 2020

Benchmark for b8680dd

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 481.0±18.55µs 476.2±15.62µs 101%
Expression (Lexer) 1938.4±35.65ns 1959.7±59.62ns 99%
Expression (Parser) 5.0±0.11µs 5.1±0.19µs 99%
Fibonacci (Execution) 3.2±0.10ms 3.2±0.08ms 101%
For loop (Execution) 508.4±13.52µs 501.3±23.12µs 101%
For loop (Lexer) 5.4±0.09µs 5.4±0.23µs 100%
For loop (Parser) 14.1±0.42µs 14.1±0.41µs 99%
Hello World (Lexer) 947.7±27.41ns 934.4±20.50ns 101%
Hello World (Parser) 2.3±0.07µs 2.3±0.08µs 99%
Symbols (Execution) 508.0±18.25µs 512.9±12.72µs 99%
undefined undefined 100%

HalidOdat
HalidOdat approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jasonwilliams
Copy link
Member

jasonwilliams commented May 8, 2020 •
edited
Loading

Looks good, you can put me (on discord?) down for contact on enforcement for now until we get an organisation sorted out.

@Razican
Copy link
Member Author

Razican commented May 9, 2020

I added the contact method in discord, until we have a better option. The Enforcement section is now this one:

Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at
discord by contacting JaseW.
All complaints will be reviewed and investigated promptly and fairly.

All community leaders are obligated to respect the privacy and security of the
reporter of any incident

Let me know @jasonwilliams if this is ok, and if you approve the PR we can merge it :)

@github-actions
Copy link

github-actions bot commented May 9, 2020

Benchmark for ea08ac9

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 401.6±25.43µs 412.4±24.37µs 97%
Expression (Lexer) 1688.2±143.22ns 1702.9±87.25ns 99%
Expression (Parser) 4.4±0.28µs 4.3±0.37µs 103%
Fibonacci (Execution) 2.7±0.17ms 2.8±0.14ms 97%
For loop (Execution) 424.8±32.62µs 448.3±100.36µs 94%
For loop (Lexer) 4.4±0.41µs 4.4±0.27µs 100%
For loop (Parser) 11.9±0.78µs 12.3±0.91µs 97%
Hello World (Lexer) 793.0±51.93ns 824.0±52.94ns 96%
Hello World (Parser) 2.0±0.08µs 2.1±0.21µs 99%
Symbols (Execution) 435.8±22.92µs 436.6±24.70µs 100%
undefined undefined 100%

@Razican Razican force-pushed the coc branch 3 times, most recently from 047003e to f63ac50 Compare May 9, 2020 11:40
@github-actions
Copy link

github-actions bot commented May 9, 2020

Benchmark for e02f727

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 466.5±14.94µs 466.6±14.09µs 100%
Expression (Lexer) 1922.7±69.11ns 1917.4±62.11ns 100%
Expression (Parser) 4.9±0.11µs 5.0±0.15µs 99%
Fibonacci (Execution) 3.1±0.08ms 3.2±0.09ms 99%
For loop (Execution) 491.3±16.49µs 492.7±18.40µs 100%
For loop (Lexer) 5.3±0.12µs 5.3±0.15µs 100%
For loop (Parser) 14.0±0.49µs 14.8±9.05µs 94%
Hello World (Lexer) 929.7±26.73ns 936.2±41.16ns 99%
Hello World (Parser) 2.3±0.06µs 2.3±0.10µs 99%
Symbols (Execution) 504.3±24.76µs 500.2±19.36µs 101%
undefined undefined 100%

@github-actions
Copy link

github-actions bot commented May 9, 2020

Benchmark for d56675c

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 395.9±27.69µs 390.7±21.34µs 101%
Expression (Lexer) 1634.2±125.91ns 1575.8±92.64ns 104%
Expression (Parser) 4.3±0.40µs 4.0±0.23µs 107%
Fibonacci (Execution) 2.9±0.16ms 2.8±0.15ms 101%
For loop (Execution) 413.3±20.18µs 425.0±29.50µs 97%
For loop (Lexer) 4.3±0.31µs 4.3±0.29µs 99%
For loop (Parser) 11.8±0.74µs 11.9±1.00µs 99%
Hello World (Lexer) 804.0±56.38ns 818.7±57.68ns 98%
Hello World (Parser) 1909.4±134.31ns 1915.0±161.53ns 100%
Symbols (Execution) 428.7±31.38µs 462.9±36.23µs 92%
undefined undefined 100%

@github-actions
Copy link

github-actions bot commented May 9, 2020

Benchmark for 44b636f

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 503.2±19.47µs 499.6±14.71µs 101%
Expression (Lexer) 2.2±0.10µs 2.5±0.07µs 86.00000000000001%
Expression (Parser) 5.3±0.21µs 5.6±0.23µs 95%
Fibonacci (Execution) 3.6±0.10ms 3.6±0.11ms 99%
For loop (Execution) 540.1±22.97µs 542.8±22.95µs 100%
For loop (Lexer) 5.9±0.24µs 6.7±0.32µs 86.00000000000001%
For loop (Parser) 15.4±0.57µs 15.6±0.72µs 99%
Hello World (Lexer) 1058.6±32.93ns 1104.0±52.13ns 96%
Hello World (Parser) 2.5±0.09µs 2.6±0.12µs 98%
Symbols (Execution) 547.5±18.77µs 553.4±57.46µs 99%
undefined undefined 100%

@Razican @jasonwilliams @HalidOdat
Added code of conduct based on Contributor Covenant 2.0
28d7970 
Co-authored-by: Jason Williams <jase.williams@gmail.com>
Co-authored-by: HalidOdat <halidodat@gmail.com>
Co-authored-by: Iban Eguia <razican@protonmail.ch>
@github-actions
Copy link

Benchmark for f1ddfef

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 390.9±10.84µs 397.1±10.67µs 98%
Expression (Lexer) 1935.5±35.65ns 1908.5±49.07ns 101%
Expression (Parser) 4.9±0.12µs 5.0±0.17µs 99%
Fibonacci (Execution) 2.8±0.12ms 2.8±0.04ms 102%
For loop (Execution) 410.2±12.10µs 418.0±16.32µs 98%
For loop (Lexer) 5.1±0.33µs 5.1±0.25µs 99%
For loop (Parser) 13.9±0.83µs 13.9±0.43µs 100%
Hello World (Lexer) 894.4±18.32ns 890.3±32.68ns 100%
Hello World (Parser) 2.2±0.08µs 2.2±0.05µs 101%
Symbols (Execution) 416.6±10.28µs 424.3±5.88µs 98%
undefined undefined 100%

@Razican
Copy link
Member Author

Razican commented May 13, 2020

Ping @jasonwilliams

@Razican Razican merged commit 44fde22 into master May 13, 2020
@Razican Razican deleted the coc branch May 13, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@jasonwilliams jasonwilliams jasonwilliams approved these changes

Assignees
No one assigned
Labels
discussion Issues needing more discussion
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Razican @jasonwilliams @HalidOdat