Patch regression from change to to-relative-to-object

[nekevss]

This fixes a regression on the tests from changes to the to_relative_to_object function.

The function was early returning an error on relativeTo being undefined, which is incorrect.

There's also a small update to the order that we fetch DiffferenceSettings to be more in line with the order in the specification.

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	48,212	48,212	0
Passed	42,737	42,875	+138
Ignored	1,413	1,413	0
Failed	4,062	3,924	-138
Panics	0	0	0
Conformance	88.64%	88.93%	+0.29%

Fixed tests (144):

test/built-ins/Temporal/PlainTime/from/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/builtin.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-plaintime.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/name.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/hour/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/smallestunit-string-shorthand.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/builtin.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/length.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/name.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/branding.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/argument-duration.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-optional-data.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/parser.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-timezone.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/missing-argument.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-duration.js (previously Failed)
test/built-ins/Temporal/Duration/from/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Duration/from/non-integer-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/from/argument-duration.js (previously Failed)
test/built-ins/Temporal/Duration/from/builtin.js (previously Failed)
test/built-ins/Temporal/Duration/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/Duration/from/length.js (previously Failed)
test/built-ins/Temporal/Duration/from/argument-string-fractional-precision.js (previously Failed)
test/built-ins/Temporal/Duration/from/name.js (previously Failed)
test/built-ins/Temporal/Duration/from/argument-object-invalid.js (previously Failed)
test/built-ins/Temporal/Duration/from/argument-existing-object.js (previously Failed)
test/built-ins/Temporal/Duration/from/string-with-skipped-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/precision-exact-in-round-duration.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/smallestunit.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/largestunit-smallestunit-default.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/relativeto-number.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/largestunit-smallestunit-mismatch.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/blank/basic.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-number.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-string-plaindatetime-invalid.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/sign-replace.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-invalid-property.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-string-negative-fractional-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-string-fractional-units-rounding-mode.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-singular-properties.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/balance-negative-result.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/branding.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/argument-invalid-property.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/argument-string-negative-fractional-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/argument-string-fractional-units-rounding-mode.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/argument-singular-properties.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/balance-negative-result.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/branding.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-trailing-junk.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/name.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-default.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/no-options.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/days-in-year.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-week.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-year.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-day.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/rounding-relative.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/days-in-month.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/branding.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/name.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/branding.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/limits.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/overflow-reject.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/overflow-constrain.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-years-weeks.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/limits.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-weeks-days.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-years-months.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/overflow-reject.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-years-months-days.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-months.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-months-weeks.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-days.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-weeks.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/add-years.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/overflow-constrain.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/equals/argument-string.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/equals/calendar-is-compared.js (previously Failed)
test/language/statements/class/elements/privatefieldset-evaluation-order-1.js (previously Failed)
test/language/statements/class/elements/super-access-inside-a-private-method.js (previously Failed)
test/staging/Temporal/Regex/old/plaindate.js (previously Failed)
test/staging/Temporal/Regex/old/duration.js (previously Failed)

Broken tests (6):

test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-duration-out-of-range.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/add/argument-duration-out-of-range.js (previously Passed)
test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/time-invalid.js (previously Passed)
test/intl402/Temporal/PlainDate/from/one-of-era-erayear-undefined.js (previously Passed)