Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temporal builtin properties #3930

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Fix temporal builtin properties #3930

merged 6 commits into from
Jul 20, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 20, 2024

This PR fixes some the properties on the Temporal builtins. Primarily, it splits the builtin name and tag into 2 statics, and adjust the length property.

Copy link

github-actions bot commented Jul 20, 2024

Test262 conformance changes

Test result main count PR count difference
Total 48,212 48,212 0
Passed 43,229 43,262 +33
Ignored 1,413 1,413 0
Failed 3,570 3,537 -33
Panics 0 0 0
Conformance 89.66% 89.73% +0.07%
Fixed tests (33):
test/built-ins/Temporal/PlainTime/name.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/length.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/length.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/length.js (previously Failed)
test/built-ins/Temporal/Instant/name.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/length.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/length.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/name.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/length.js (previously Failed)
test/built-ins/Temporal/Duration/name.js (previously Failed)
test/built-ins/Temporal/Duration/length.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/length.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/name.js (previously Failed)
test/built-ins/Temporal/PlainDate/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/with/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/length.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/name.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/length.js (previously Failed)

@jedel1043 jedel1043 requested a review from a team July 20, 2024 17:58
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jedel1043 jedel1043 requested a review from a team July 20, 2024 17:58
@jedel1043 jedel1043 added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jul 20, 2024
@jedel1043 jedel1043 added this to the next-release milestone Jul 20, 2024
@raskad raskad added this pull request to the merge queue Jul 20, 2024
Merged via the queue into main with commit 99642be Jul 20, 2024
13 checks passed
@jedel1043 jedel1043 deleted the fix-temporal-properties branch July 20, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants