Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Atomics.pause #3956

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Implement Atomics.pause #3956

merged 1 commit into from
Aug 24, 2024

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Aug 18, 2024
@jedel1043 jedel1043 added this to the next-release milestone Aug 18, 2024
@jedel1043 jedel1043 requested a review from a team August 18, 2024 08:28
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,212 48,476 +264
Passed 43,346 43,453 +107
Ignored 1,413 1,500 +87
Failed 3,453 3,523 +70
Panics 0 0 0
Conformance 89.91% 89.64% -0.27%
Broken tests (2): 
test/harness/asyncHelpers-throwsAsync-func-throws-sync.js (previously Passed)
test/harness/asyncHelpers-throwsAsync-no-arg.js (previously Passed)

jasonwilliams
jasonwilliams approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume the clamping to u16 is to prevent blocking for too long.

@jedel1043
Copy link
Member Author

jedel1043 commented Aug 23, 2024 •
edited
Loading

LGTM, I assume the clamping to u16 is to prevent blocking for too long.

Yes, blocking for u32::MAX is a bit too much (2s), but blocking for u16::MAX takes a couple of micros.

raskad
raskad approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@raskad raskad added this pull request to the merge queue Aug 24, 2024
Merged via the queue into main with commit af4fd5a Aug 24, 2024
13 checks passed
@jedel1043 jedel1043 deleted the atomics-pause branch August 24, 2024 15:09
hansl added a commit to hansl/boa that referenced this pull request Sep 6, 2024
@hansl
Revert "Implement Atomics.pause (boa-dev#3956)"
c9dec62 
This reverts commit af4fd5a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@jasonwilliams jasonwilliams jasonwilliams approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @jasonwilliams @raskad