Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TryFromJs for TypedJsFunction and more tests #3981

Merged
merged 9 commits into from
Sep 22, 2024
Merged

Add TryFromJs for TypedJsFunction and more tests #3981

merged 9 commits into from
Sep 22, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Sep 5, 2024

Includes adding TryFromJs for "()".

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.36%. Comparing base (6ddc2b4) to head (a66b545).
Report is 258 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/object/builtins/jsfunction.rs 40.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3981      +/-   ##
==========================================
+ Coverage   47.24%   51.36%   +4.12%     
==========================================
  Files         476      470       -6     
  Lines       46892    45244    -1648     
==========================================
+ Hits        22154    23240    +1086     
+ Misses      24738    22004    -2734

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HalidOdat
HalidOdat approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a minor nitpick :)

core/engine/src/object/builtins/jsfunction.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added enhancement New feature or request API labels Sep 11, 2024
@HalidOdat HalidOdat added this to the next-release milestone Sep 11, 2024
@HalidOdat HalidOdat requested a review from a team September 11, 2024 12:56
@HalidOdat HalidOdat requested a review from a team September 12, 2024 04:55
jedel1043
jedel1043 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jedel1043 jedel1043 added this pull request to the merge queue Sep 22, 2024
Merged via the queue into boa-dev:main with commit 8438ad2 Sep 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hansl @HalidOdat @jedel1043