Add an "iter()" method to Js*Array for convenience #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be optimizable, and in either case it should be but this at least let people use an easy API and enjoy future improvements.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3986 +/- ##
==========================================
+ Coverage 47.24% 51.79% +4.54%
==========================================
Files 476 468 -8
Lines 46892 45223 -1669
==========================================
+ Hits 22154 23421 +1267
+ Misses 24738 21802 -2936 ☔ View full report in Codecov by Sentry. |
jedel1043
approved these changes
Sep 9, 2024
hansl
added a commit
to hansl/boa
that referenced
this pull request
Sep 12, 2024
* Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` * Add an "iter()" method to Js*Array for convenience It might be optimizable, and in either case it should be but this at least let people use an easy API and enjoy future improvements. * Fix clippies --------- Co-authored-by: Theo Paris <theo@tinted.dev> Co-authored-by: José Julián Espina <julian.espina@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be optimizable, and in either case it should be but this at
least let people use an easy API and enjoy future improvements.