Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dockerfile from documentation #4046

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

4yman-0
Copy link
Contributor

@4yman-0 4yman-0 commented Nov 19, 2024

This Pull Request fixes/closes #4016.

It changes the following:

  • CONTRIBUTING.md
  • docs/debugging.md
    By removing all references to a Dockerfile that no longer exists.

Edit 1: Fix typo

Remove two lines referencing an absent Dockerfile.
Remove one phrase referencing an absent Dockerfile
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.88%. Comparing base (6ddc2b4) to head (72bd946).
Report is 295 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
+ Coverage   47.24%   52.88%   +5.64%     
==========================================
  Files         476      483       +7     
  Lines       46892    46947      +55     
==========================================
+ Hits        22154    24829    +2675     
+ Misses      24738    22118    -2620     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jedel1043 jedel1043 added the documentation update documentation label Nov 19, 2024
@jedel1043 jedel1043 added this pull request to the merge queue Nov 19, 2024
@jedel1043 jedel1043 added this to the next-release milestone Nov 19, 2024
Merged via the queue into boa-dev:main with commit 55532c0 Nov 19, 2024
14 checks passed
@4yman-0 4yman-0 deleted the rm-docker-docs branch November 20, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Dockerfile
3 participants